1. Luke Plant
  2. semanticeditor
  3. Issues
Issue #20 on hold

Renaming a style

evildmp
created an issue

Say the user renames the style //tint1// to //gloomy// in the Admin.

The option for //tint1// will of of course no longer be available in the editor, but it will all the same remain applied to the code that is being served up.

It lives on until the WYMeditor plugin has been saved again.

Could the system, when a class name is changed, scoot through all the pages and apply the change appropriately.

Comments (3)

  1. Luke Plant repo owner

    It's possible, though it could be tricky, and quite an expensive operation. It would have to load every piece of HTML content in the database, parse it, find all 'class' attributes and replace them, and write back out to the database again. Once you move beyond toy sites, that will take a significant amount of time to do, and so you would really need to do in a separate process (otherwise when the user presses 'Save' the page will simply hang until the process is done, and you could easily get time-outs etc.). If you need a separate process, then you need some kind of queue system - like http://code.google.com/p/django-queue-service/ . That isn't a problem by itself, but I think it means you could not have this feature enabled by default -- you could provide the functionality in the semanticeditor app, but would require developers to hook it up themselves. This would be easy to do using Django's signal functionality and something like that queue service.

    There might also be the issue that not every piece of HTML content should be changed in this way.

  2. evildmp reporter

    OK - I think this is something that can be safely relegated to the status of future enhancement rather than crucial first-release functionality, so I've marked it as on-hold.

  3. Log in to comment