#8 Open
Repository
evildmp evildmp
Branch
get-classes-issue
Repository
spookylukey spookylukey
Branch
default

test classes

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r get-classes-issue https://bitbucket.org/evildmp/semanticeditor
hg merge get-classes-issue
hg commit -m 'Merged in evildmp/semanticeditor/get-classes-issue (pull request #8)'
Author
  1. evildmp avatarevildmp
Reviewers
Description

I proposed https://bitbucket.org/spookylukey/semanticeditor/pull-request/5/better-way-of-getting-class-list-in-editor/diff as a solution to https://bitbucket.org/spookylukey/semanticeditor/issue/45/multiselectfield-doesnt-like-being

The problem though is still extant.

When a CssClass with a null templates attribute is saved, templates is saved as [u''] rather than [], so the check for templates in models.get_classes() won't find it.

The test attached fails because of this.

Comments (0)

Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.