1. Luke Plant
  2. semanticeditor

Pull requests

#2 Declined
Repository
evildmp
Branch
default
Repository
spookylukey
Branch
default

better defaults for templates & classes

Author
  1. evildmp
Reviewers
Description

Since many classes will apply to all templates, it makes sense to make it easier to do that.

So in the editor, a class should be available to all templates unless some templates are specified for that style.

This will also make it easier to supply useful default styles in a fixture.

  • Learn about pull requests

Comments (2)

  1. evildmp author

    Sorry, that should actually be:

    return [c for c in classes if c.templates == [u''] or template in c.templates]

    on line 65, because no templates is [u''], not None.

  2. Luke Plant repo owner

    And the help text is added to the wrong field.

    Would you mind trying again, and sending me a pull request for a correct version? If you just "hg update -r 1541c00537b7" then you can ignore these commits and try again.

    Thanks.