Commits

Doug Hellmann committed 769e9d3

use tempfile to create temporary files instead of the process id so the filenames are less predictable

  • Participants
  • Parent commits 8654da8

Comments (0)

Files changed (2)

docs/source/history.rst

 
   - Add support for ksh.  Thanks to Doug Latornell for doing the
     research on what needed to be changed.
+  - Switch to ``tempfile`` command for creating temporary hook files.
 
 2.0.2
 

virtualenvwrapper.sh

     # First anything that runs directly from the plugin
     "$VIRTUALENVWRAPPER_PYTHON" -m virtualenvwrapper.hook_loader $HOOK_VERBOSE_OPTION "$@"
     # Now anything that wants to run inside this shell
+    hook_script=$(tempfile --directory "$VIRTUALENVWRAPPER_TMPDIR")
     "$VIRTUALENVWRAPPER_PYTHON" -m virtualenvwrapper.hook_loader $HOOK_VERBOSE_OPTION \
-        --source "$@" >>$VIRTUALENVWRAPPER_TMPDIR/$$.hook
-    source $VIRTUALENVWRAPPER_TMPDIR/$$.hook
-    rm -f $VIRTUALENVWRAPPER_TMPDIR/$$.hook
+        --source "$@" >>"$hook_script"
+    source "$hook_script"
+    rm -f "$hook_script"
 }
 
 # Set up virtualenvwrapper properly