Anonymous committed 03993e1

index-pack: Track the object_entry that creates each base_data

If we free the data stored within a base_data we need the struct
object_entry to get the data back again for use with another dependent
delta. Storing the object_entry* in base_data makes it simple to call
get_data_from_pack() to recover the compressed information.

This however means that we must add the missing base object to the end of
our packfile prior to calling resolve_delta() on each of the dependent
deltas. Adding the base first ensures we can read the base back from the
pack we are indexing, as if it had been included by the remote side.

Signed-off-by: Shawn O. Pearce <>
Signed-off-by: Junio C Hamano <>

Comments (0)

Files changed (1)

 struct base_data {
 	struct base_data *base;
 	struct base_data *child;
+	struct object_entry *obj;
 	void *data;
 	unsigned long size;
 	sha1_object(, result.size, type, delta_obj->idx.sha1);
+	result.obj = delta_obj;
 	link_base_data(base_obj, &result);
 	hashcpy(delta_base.sha1, delta_obj->idx.sha1);
 			continue; = get_data_from_pack(obj);
 		base_obj.size = obj->size;
+		base_obj.obj = obj;
 		link_base_data(NULL, &base_obj);
 		if (ref)
 	return size;
-static void append_obj_to_pack(const unsigned char *sha1, void *buf,
+static struct object_entry *append_obj_to_pack(
+			       const unsigned char *sha1, void *buf,
 			       unsigned long size, enum object_type type)
 	struct object_entry *obj = &objects[nr_objects++];
 	obj[1].idx.offset = obj[0].idx.offset + n;
 	obj[1].idx.offset += write_compressed(output_fd, buf, size, &obj[0].idx.crc32);
 	hashcpy(obj->idx.sha1, sha1);
+	return obj;
 static int delta_pos_compare(const void *_a, const void *_b) = read_sha1_file(d->base.sha1, &type, &base_obj.size);
 		if (!
+		if (check_sha1_signature(d->base.sha1,,
+				base_obj.size, typename(type)))
+			die("local object %s is corrupt", sha1_to_hex(d->base.sha1));
+		base_obj.obj = append_obj_to_pack(d->base.sha1,,
+			base_obj.size, type);
 		link_base_data(NULL, &base_obj);
 		find_delta_children(&d->base, &first, &last);
 				resolve_delta(child, &base_obj, type);
-		if (check_sha1_signature(d->base.sha1,,
-				base_obj.size, typename(type)))
-			die("local object %s is corrupt", sha1_to_hex(d->base.sha1));
-		append_obj_to_pack(d->base.sha1,,
-			base_obj.size, type);
 		display_progress(progress, nr_resolved_deltas);