Junio C Hamano  committed 0fb1eaa

unpack-trees: make sure "" is NUL terminated.

The structure that ends with a flexible array member (or 0
length array with older GCC) "char name[FLEX_ARRAY]" is
allocated on the stack and we use it after clearing its entire
size with memset. That does not guarantee that "name" is
properly NUL terminated as we intended on platforms with more
forgiving structure alignment requirements.

Reported breakage on m68k by Roman Zippel.

Signed-off-by: Junio C Hamano <>

  • Participants
  • Parent commits 562cefb

Comments (0)

Files changed (1)

File unpack-trees.c

 	int i;
 	struct object_list *posn = trees;
 	struct tree_entry_list df_conflict_list;
-	struct cache_entry df_conflict_entry;
+	static struct cache_entry *dfc;
 	memset(&df_conflict_list, 0, sizeof(df_conflict_list)); = &df_conflict_list;
 	state.refresh_cache = 1;
 	o->merge_size = len;
-	memset(&df_conflict_entry, 0, sizeof(df_conflict_entry));
-	o->df_conflict_entry = &df_conflict_entry;
+	if (!dfc)
+		dfc = xcalloc(1, sizeof(struct cache_entry) + 1);
+	o->df_conflict_entry = dfc;
 	if (len) {
 		posns = xmalloc(len * sizeof(struct tree_entry_list *));