Anonymous committed 3ef6a1f

t5516: remove ambiguity test (1)

This test tried to push into a remote with ambiguous refs in
remotes/$x/master and remotes/$y/master. However, the remote
never actually tells us about the refs/remotes hierarchy, so
we don't even see this ambiguity.

The test happened to pass because we were simply looking for
failure, and the test fails for another reason: the dst
refspec does not exist and does not begin with refs/, making
it invalid.

Signed-off-by: Jeff King <>
Signed-off-by: Junio C Hamano <>

  • Participants
  • Parent commits 837f3b7

Comments (0)

Files changed (1)

File t/

-test_expect_success 'push with ambiguity (1)' '
-	mk_test remotes/origin/master remotes/frotz/master &&
-	if git push testrepo master:master
-	then
-		echo "Oops, should have failed"
-		false
-	else
-		check_push_result $the_first_commit remotes/origin/master remotes/frotz/master
-	fi
-test_expect_success 'push with ambiguity (2)' '
+test_expect_success 'push with ambiguity' '
 	mk_test heads/frotz tags/frotz &&
 	if git push testrepo master:frotz