Jeff King  committed 4f6a32f

commit: abort commit if interactive add failed

Previously we ignored the result of calling add_interactive,
which meant that if an error occurred we simply committed
whatever happened to be in the index.

Signed-off-by: Jeff King <>
Signed-off-by: Junio C Hamano <>

  • Participants
  • Parent commits e1dc49b
  • Branches master

Comments (0)

Files changed (1)

File builtin-commit.c

 	const char **pathspec = NULL;
 	if (interactive) {
-		interactive_add(argc, argv, prefix);
+		if (interactive_add(argc, argv, prefix) != 0)
+			die("interactive add failed");
 		if (read_cache() < 0)
 			die("index file corrupt");
 		commit_style = COMMIT_AS_IS;