robbat2  committed 5cd3e10

Fix false positives in t3404 due to SHELL=/bin/false

If the user's shell in NSS passwd is /bin/false (eg as found during Gentoo's
package building), the git-rebase exec tests will fail, because they call
$SHELL around the command, and in the existing testcase, $SHELL was not being
cleared sufficently.

This lead to false positive failures of t3404 on systems where the package
build user was locked down as noted above.

Signed-off-by: "Robin H. Johnson" <>
X-Gentoo-Bug: 349083
Signed-off-by: Junio C Hamano <>

  • Participants
  • Parent commits 26517de

Comments (0)

Files changed (1)

File t/

 # "exec" commands are ran with the user shell by default, but this may
 # be non-POSIX. For example, if SHELL=zsh then ">file" doesn't work
 # to create a file. Unseting SHELL avoids such non-portable behavior
-# in tests.
+# in tests. It must be exported for it to take effect where needed.
+export SHELL
 test_expect_success 'rebase -i with the exec command' '
 	git checkout master &&