Jindrich Makovicka  committed 60204dd

git-gui: suppress RenderBadPicture X error caused by Tk bug

Due to a bug in Tk, git-gui almost always (unless git-gui is closed
right after starting) produces an X window error message on exit,
something like:

X Error of failed request: RenderBadPicture (invalid Picture parameter)
Major opcode of failed request: 150 (RENDER)
Minor opcode of failed request: 7 (RenderFreePicture)
Picture id in failed request: 0x3a000dc
Serial number of failed request: 1965
Current serial number in output stream: 1980

Respective Tk bug report is here:

This bug is triggered only when the send command is blocked via
rename send {} . The following patch re-enables send just before
quiting git-gui to suppress the error.

Signed-off-by: Jindrich Makovicka <>
Signed-off-by: Shawn O. Pearce <>

  • Participants
  • Parent commits 1085208
  • Branches master

Comments (0)

Files changed (1)

 	set ret_code $rc
+	# Briefly enable send again, working around Tk bug
+	#
+	tk appname [appname]
 	destroy .