Anonymous committed 69e66f5

rebase --interactive: Compute upstream SHA1 before switching branches

If the upstream argument to rebase (the first argument) was relative to
HEAD and the name of the branch to rebase (the second argument) was given,
the upstream would have been interpreted relative to the second argument.
In particular, this command

git rebase -i HEAD topic

would always finish with "Nothing to do". (a1bf91e fixed the same issue
for non-interactive rebase.)

Signed-off-by: Johannes Sixt <>
Acked-by: Johannes Schindelin <>
Signed-off-by: Junio C Hamano <>

  • Participants
  • Parent commits c5833f6

Comments (0)

Files changed (1)


+		UPSTREAM=$(git rev-parse --verify "$1") || die "Invalid base"
+		test -z "$ONTO" && ONTO=$UPSTREAM
 		if test ! -z "$2"
 			output git show-ref --verify --quiet "refs/heads/$2" ||
 		HEAD=$(git rev-parse --verify HEAD) || die "No HEAD?"
-		UPSTREAM=$(git rev-parse --verify "$1") || die "Invalid base"
 		mkdir "$DOTEST" || die "Could not create temporary $DOTEST"
-		test -z "$ONTO" && ONTO=$UPSTREAM
 		: > "$DOTEST"/interactive || die "Could not mark as interactive"
 		git symbolic-ref HEAD > "$DOTEST"/head-name 2> /dev/null ||
 			echo "detached HEAD" > "$DOTEST"/head-name