1. Stefan Saasen
  2. git


veillette@yahoo.ca  committed 6a589fd

filter-branch: Fix renaming a directory in the tree-filter

Commit d89c1df (filter-branch: don't use xargs -0, 2008-03-12) replaced a
'ls-files | xargs rm' pipeline by 'git clean'. 'git clean' however does
not recurse and remove directories by default.

Now, consider a tree-filter that renames a directory.

1. For the first commit everything works as expected

2. Then filter-branch checks out the files for the next commit. This
leaves the new directory behind because there is no real "branch
switching" involved that would notice that the directory can be

3. Then filter-branch invokes 'git clean' to remove exactly those
left-overs. But here it does not remove the directory.

4. The next tree-filter does not work as expected because there already
exists a directory with the new name.

Just add -d to 'git clean', so that empty directories are removed.

Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

  • Participants
  • Parent commits 9035628
  • Branches master

Comments (0)

Files changed (2)

File git-filter-branch.sh

View file
  • Ignore whitespace
 			die "Could not checkout the index"
 		# files that $commit removed are now still in the working tree;
 		# remove them, else they would be added again
-		git clean -q -f -x
+		git clean -d -q -f -x
 		eval "$filter_tree" < /dev/null ||
 			die "tree filter failed: $filter_tree"

File t/t7003-filter-branch.sh

View file
  • Ignore whitespace
 	git-filter-branch -f --tree-filter "mv dir diroh || :" HEAD
-test_expect_failure 'test that the directory was renamed' '
+test_expect_success 'test that the directory was renamed' '
 	test dir/d = "$(git show HEAD:diroh/d --)" &&
 	! test -d dir &&
 	test -d diroh &&