1. Stefan Saasen
  2. git


Linus Torvalds  committed 8805cca

[PATCH] Avoid building object ref lists when not needed

The object parsing code builds a generic "this object references that
object" because doing a full connectivity check for fsck requires it.

However, nothing else really needs it, and it's quite expensive for
git-rev-list that can have tons of objects in flight.

So, exactly like the commit buffer save thing, add a global flag to
disable it, and use it in git-rev-list.


$ /usr/bin/time git-rev-list --objects v2.6.12..HEAD | wc -l
12.28user 0.29system 0:12.57elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+26718minor)pagefaults 0swaps

After this change:

$ /usr/bin/time git-rev-list --objects v2.6.12..HEAD | wc -l
10.33user 0.18system 0:10.54elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+18509minor)pagefaults 0swaps

and note how the number of pages touched by git-rev-list for this
particular object list has shrunk from 26,718 (104 MB) to 18,509 (72 MB).

Calculating the total object difference between two git revisions is still
clearly the most expensive git operation (both in memory and CPU time),
but it's now less than 40% of what it used to be.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>

  • Participants
  • Parent commits b0d8923
  • Branches master

Comments (0)

Files changed (3)

File object.c

View file
  • Ignore whitespace
 int nr_objs;
 static int obj_allocs;
+int track_object_refs = 1;
 static int find_object(const unsigned char *sha1)
 	int first = 0, last = nr_objs;
 void add_ref(struct object *refer, struct object *target)
-	struct object_list **pp = &refer->refs;
-	struct object_list *p;
+	struct object_list **pp, *p;
+	if (!track_object_refs)
+		return;
+	pp = &refer->refs;
 	while ((p = *pp) != NULL) {
 		if (p->item == target)
 	struct object_list *p = obj->refs;
+	if (!track_object_refs)
+		die("cannot do reachability with object refs turned off");
 	/* If we've been here already, don't bother */
 	if (obj->flags & mask)

File object.h

View file
  • Ignore whitespace
 	void *util;
+extern int track_object_refs;
 extern int nr_objs;
 extern struct object **objs;

File rev-list.c

View file
  • Ignore whitespace
 	save_commit_buffer = verbose_header;
+	track_object_refs = 0;
 	if (!merge_order) {