Øyvind A. Holm committed 9979a50 Add missing comma to CC_LD_DYNPATH

40bfbde ("build: don't duplicate substitution of make variables",
2012-09-11) by mistake removed a necessary comma at the end of
"CC_LD_DYNPATH=-Wl,rpath," in line 414.

When executing "./configure --with-zlib=PATH", this resulted in

CC xdiff/xhistogram.o
AR xdiff/lib.a
LINK git-credential-store
/usr/bin/ld: bad -rpath option
collect2: ld returned 1 exit status
make: *** [git-credential-store] Error 1

during make.

Signed-off-by: Øyvind A. Holm <>
Acked-by: Stefano Lattarini <>
Signed-off-by: Junio C Hamano <>

  • Participants
  • Parent commits 4c6c949

Comments (0)

Files changed (1)

    if test "$git_cv_ld_wl_rpath" = "yes"; then
-      CC_LD_DYNPATH=-Wl,-rpath
+      CC_LD_DYNPATH=-Wl,-rpath,
       AC_CACHE_CHECK([if linker supports -rpath], git_cv_ld_rpath, [