Commits

Anonymous committed 9ae6be8

git-commit -v: have patch at the end.

It was pointed out that otherwise more important summary
information prefixed with '#' would become prone to be missed.

Also instead of chopping at the first '^---$' line, stop at the
first 'diff --git a/' line.

Signed-off-by: Junio C Hamano <junkio@cox.net>

  • Participants
  • Parent commits 9da5c2f

Comments (0)

Files changed (1)

 
 	if test -z "$initial_commit"
 	then
-	    if test -z "$verbose"
-	    then
-		git-diff-index -M --cached --name-status \
-		    --diff-filter=MDTCRA HEAD |
-		sed -e '
-			s/\\/\\\\/g
-			s/ /\\ /g
-		' |
-		report "Updated but not checked in" "will commit"
-	    else
-	        if git-diff-index --cached -M -p --diff-filter=MDTCRA HEAD |
-		   grep .
-		then
-		   false
-		else
-		   true
-		fi
-	    fi
+	    git-diff-index -M --cached --name-status \
+		--diff-filter=MDTCRA HEAD |
+	    sed -e '
+		    s/\\/\\\\/g
+		    s/ /\\ /g
+	    ' |
+	    report "Updated but not checked in" "will commit"
 	    committable="$?"
 	else
 	    echo '#
 		print "$_\n";
 	    }
 	'
+
+	if test -n "$verbose"
+	then
+	    git-diff-index --cached -M -p --diff-filter=MDTCRA HEAD
+	fi
 	case "$committable" in
 	0)
 	    echo "nothing to commit"
 	PARENTS=""
 fi
 
-{
-    test -z "$verbose" || echo '---'
-    run_status
-} >>"$GIT_DIR"/COMMIT_EDITMSG
+run_status >>"$GIT_DIR"/COMMIT_EDITMSG
 if [ "$?" != "0" -a ! -f "$GIT_DIR/MERGE_HEAD" ]
 then
 	rm -f "$GIT_DIR/COMMIT_EDITMSG"
 esac
 
 sed -e '
-	/^---$/{
-		s///
-		q
-	}
-	/^#/d
+    /^diff --git a\/.*/{
+	s///
+	q
+    }
+    /^#/d
 ' "$GIT_DIR"/COMMIT_EDITMSG |
 git-stripspace >"$GIT_DIR"/COMMIT_MSG