Anonymous committed a2b26ac

clone: detect and fail on excess parameters

"git clone [options] $src $dst excess-garbage" simply ignored
excess-garbage without giving any diagnostic message. Fix it.

Signed-off-by: Junio C Hamano <>

Comments (0)

Files changed (2)

 if test -n "$2"
+	test $# == 2 || die "excess parameter to git-clone"
 	# Derive one from the repository name
 	# Try using "humanish" part of source repo if user didn't specify one
+. ./
+test_expect_success setup '
+	rm -fr .git &&
+	test_create_repo src &&
+	(
+		cd src
+		>file
+		git add file
+		git commit -m initial
+	)
+test_expect_success 'clone with excess parameters' '
+	test_must_fail git clone -n "file://$(pwd)/src" dst junk
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.