Nguyễn Thái Ngọc Duy  committed b4524d3

revert: do not pass non-literal string as format to git_path()

This fixes the following warning.

CC builtin/revert.o
builtin/revert.c: In function ‘write_cherry_pick_head’:
builtin/revert.c:311: warning: format not a string literal and no format arguments

Signed-off-by: Nguyễn Thái Ngọc Duy <>
Signed-off-by: Junio C Hamano <>

  • Participants
  • Parent commits 017d1e1

Comments (0)

Files changed (1)

File builtin/revert.c

 	strbuf_addf(&buf, "%s\n", sha1_to_hex(commit->object.sha1));
-	filename = git_path(pseudoref);
+	filename = git_path("%s", pseudoref);
 	fd = open(filename, O_WRONLY | O_CREAT, 0666);
 	if (fd < 0)
 		die_errno(_("Could not open '%s' for writing"), filename);