Anonymous committed e44b5d1

Remove pointless calls to access(2) when checking for .mailmap

read_mailmap already returns not 0 in case of error, and nothing
seem to be interested in it. It also is silent about the fact
(read_mailmap being to chatty would justify the call to access,
but there is no point for it to be and it isn't).

Signed-off-by: Alex Riesen <>
Signed-off-by: Junio C Hamano <>

  • Participants
  • Parent commits 8503ee4

Comments (0)

Files changed (2)

 		die("reading graft file %s failed: %s",
 		    revs_file, strerror(errno));
-	if (!no_mailmap && !access(".mailmap", R_OK))
+	if (!no_mailmap)
 		read_mailmap(&mailmap, ".mailmap", NULL);
 	assign_blame(&sb, &revs, opt);


 	if (argc > 1)
 		die ("unrecognized argument: %s", argv[1]);
-	if (!access(".mailmap", R_OK))
-		read_mailmap(&mailmap, ".mailmap", &common_repo_prefix);
+	read_mailmap(&mailmap, ".mailmap", &common_repo_prefix);
 	if ( == 0) {
 		if (isatty(0))