1. Stefan Saasen
  2. git


Jeff King  committed ea2d4ed

commit: fix "--amend --only" with no pathspec

When we do not have any pathspec, we typically disallow an
explicit "--only", because it makes no sense (your commit
would, by definition, be empty). But since 6a74642
(git-commit --amend: two fixes., 2006-04-20), we have
allowed "--amend --only" with the intent that it would amend
the commit, ignoring any contents staged in the index.

However, while that commit allowed the combination, we never
actually implemented the logic to make it work. The current
code notices that we have no pathspec and assumes we want to
do an as-is commit (i.e., the "--only" is ignored).

Instead, we must make sure to follow the partial-commit
code-path. We also need to tweak the list_paths function to
handle a NULL pathspec.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

  • Participants
  • Parent commits cbcab75
  • Branches master

Comments (0)

Files changed (2)

File builtin-commit.c

View file
  • Ignore whitespace
 	int i;
 	char *m;
+	if (!pattern)
+		return 0;
 	for (i = 0; pattern[i]; i++)
 	m = xcalloc(1, i);
 	 * hooks on the real index, and create commit from the_index.
 	 * We still need to refresh the index here.
-	if (!pathspec || !*pathspec) {
+	if (!only && (!pathspec || !*pathspec)) {
 		fd = hold_locked_index(&index_lock, 1);
 		if (write_cache(fd, active_cache, active_nr) ||

File t/t7501-commit.sh

View file
  • Ignore whitespace
 	"amend commit" \
 	"EDITOR=./editor git commit --amend"
+test_expect_success 'amend --only ignores staged contents' '
+	cp file file.expect &&
+	echo changed >file &&
+	git add file &&
+	git commit --no-edit --amend --only &&
+	git cat-file blob HEAD:file >file.actual &&
+	test_cmp file.expect file.actual &&
+	git diff --exit-code
 test_expect_success \
 	"passing -m and -F" \
 	"echo 'enough with the bongos' >file && \