Shawn O. Pearce  committed ef203f0

Catch write_ref_sha1 failure in receive-pack

This failure to catch the failure of write_ref_sha1 was noticed
by Bill Lear. The ref will not update if the log file could not
be appended to (due to file permissions problems). Such a failure
should be flagged as a failure to update the ref, so that the client
knows the push did not succeed.

Signed-off-by: Shawn O. Pearce <>
Signed-off-by: Junio C Hamano <>

  • Participants
  • Parent commits 58db64f

Comments (0)

Files changed (1)

File receive-pack.c

 			cmd->error_string = "failed to lock";
 			return error("failed to lock %s", name);
-		write_ref_sha1(lock, new_sha1, "push");
+		if (write_ref_sha1(lock, new_sha1, "push")) {
+			cmd->error_string = "failed to write";
+			return -1; /* error() already called */
+		}
 		fprintf(stderr, "%s: %s -> %s\n", name, old_hex, new_hex);
 	return 0;