Add git_cmd_path and hg_cmd_path

#2 Merged at 9ce3616
Repository
yuji_developer
Branch
master
Repository
steveqian
Branch
master
Author
  1. Yuji Hanamura
Reviewers
Description

Hello steveqx,

Thank you for the useful redmine plugin. I added two parameters, hg_cmd_path and git_cmd_path. And small bug fix in lig/bitucket_git.rb. Could you merge this?

Thanks, Yuji

Comments (5)

  1. Steve Qian repo owner

    Yuji,

    Thanks for the patch, indeed I should consider this feature. However, since the scm command path can be configured in config/configuration.yml, we should not add our own settings in the plugin, but rather take from that config file instead.

    could you make the changes and resubmit the patch?

    Thanks.

    Steve

  2. Yuji Hanamura author

    Hi Steve,

    Thank you for your review. You right. I've updated the patch to load scm path from configuration.yml. Could you check this?

    Thanks,

    Yuji

  3. Steve Qian repo owner

    Hi Yuji,

    the "cmd" should be a member of the BitbucketGit /BitbucketHg class, thus there should be no changes to the BitbucketAdapter class.

    The change can be something like this:

    class BitbucketGit < SystemCommand
    
      GIT_BIN = Redmine::Configuration['scm_git_command'] || "git"
    
      def self.scm_class
        Repository::Git
    

    Sorry for the trouble, I could have do it myself. Thank you very much for the support.