1. Tarek Ziadé
  2. distribute

Pull requests

#2 Declined
Repository
pkoch
Branch
default
Repository
tarek
Branch
default

Add support for git and Mercurial URLs.

Author
  1. Paulo Köch
Reviewers
Description

I just mimicked the code for svn.

  • Learn about pull requests

Comments (4)

  1. Jason R. Coombs

    A few of suggestions:

    1. The additional "if" statements around line 659 don't pass the elif properly. At the very least, each additional if statement should be an elif.
    2. hg+ and git+ URLs may not be appropriate. In SVN, the expected URLs are "svn+ssh:..."; is this the same for git/hg?
    3. In SVN, it's a valid URL to have svn:someserver, which says use the SVN protocol on the SVN port to connect directly to the service. I don't believe this is supported in git/hg. Should this scheme be supported at all?

    Can you provide some examples of how you imagine this being used?

    Finally, there should probably be some updates to the documentation reflecting these changes. 4. Comments still refer to SVN.

    1. Paulo Köch author

      The additional "if" statements around line 659 don't pass the elif properly. At the very least, each additional if statement should be an elif.

      You're absolutely right. I'll correct that.

      hg+ and git+ URLs may not be appropriate. In SVN, the expected URLs are "svn+ssh:..."; is this the same for git/hg?

      I was following the style defined in pip. See http://www.pip-installer.org/en/latest/requirement-format.html

      In SVN, it's a valid URL to have svn:someserver, which says use the SVN protocol on the SVN port to connect directly to the service. I don't believe this is supported in git/hg. Should this scheme be supported at all?

      Very well pointed out. I made the git patch and thought the mercurial one would be just a small variation. As you point out, it's not. I'll change the patch to only accept valid schemes.

      Can you provide some examples of how you imagine this being used?

      I made this change because I plan on using it to refer private repositories without having to keep tarballs for all the revisions I want to deploy. That would be too cumbersome/wasteful on a continuous deployment scenario.

      Finally, there should probably be some updates to the documentation reflecting these changes.

      Doh! Overlooked it. Is there any other place I might have also overlooked? Tests? Other documentation?

      Thank you for your input! I'll revise my pull request shortly^W as soon as I get to a machine with hg.