1. Tarek Ziadé
  2. distribute

Pull requests

#39 Merged
Repository
jaraco
Branch
default
Repository
tarek
Branch
default

Support ARM plus build Windows launchers using Windows SDK

Author
  1. Jason R. Coombs
Reviewers
Description

This is a new pull request to supersede pull request #37. It includes the changes by Grigory Petrov refactored to my liking (thanks). Plus, it includes new changes to the builder to use the MS Windows SDK instead of requiring Visual Studio.

Grigory - can you review the changes I made, in particular 3bb4cc5, where I use the SDK instead of Visual Studio. It worked for me. Can you forsee any issues with that change? Is there any disadvantage to preferring the SDK over Visual Studio?

  • Learn about pull requests

Comments (1)

  1. Grigory Petrov

    Hello.

    Thanks a lot for sorting this out. Using SDK instead of Visual Studio is actually better, since Visual Studio is an end-user product plagued by many versions and license restrictions (Express can't compile 32-bi etc), while SDK was always intended for software developers.

    I have checked code and added my suggestions as comments.