1. Tarek Ziadé
  2. flake8


Ian Cordasco  committed ec85a54

Fix #91 (bitbucket)

Non python files were being included in the git hook. Also, I realized that
with --install-hook on git projects, the file was not readable to the user.
Using binary helps clarify the use of chmod since I had erroneously used the
744 like the commandline does.

  • Participants
  • Parent commits b3117c3
  • Branches default

Comments (0)

Files changed (1)

File flake8/hooks.py

View file
     gitcmd = "git diff-index --cached --name-only HEAD"
     if lazy:
+        # Catch all files, including those not added to the index
         gitcmd = gitcmd.replace('--cached ', '')
     if hasattr(ignore, 'split'):
         ignore = ignore.split(',')
+    # Returns the exit code, list of files modified, list of error messages
     _, files_modified, _ = run(gitcmd)
+    # Run the checks
     flake8_style = get_style_guide(
         config_file=DEFAULT_CONFIG, ignore=ignore, max_complexity=complexity)
-    report = flake8_style.check_files(files_modified)
+    report = flake8_style.check_files([f for f in files_modified if
+                                       f.endswith('.py')])
     if strict:
         return report.total_errors
     if 'git' in vcs:
         with open(vcs, 'w+') as fd:
-        os.chmod(vcs, 744)
+        # 0b111100100 == rwxr--r--
+        os.chmod(vcs, 0b111100100)
     elif 'hg' in vcs: