Commits

tbrugz committed bd015fa

fixing some findbugs issues

  • Participants
  • Parent commits 1da8d67

Comments (0)

Files changed (6)

src/tbrugz/sqldump/datadump/DataDumpUtils.java

 	static boolean resultSetWarnedForSQLValue = false;
 	
 	//see: http://download.oracle.com/javase/1.5.0/docs/api/java/text/SimpleDateFormat.html
-	public static DateFormat dateFormatter = new SimpleDateFormat("yyyy-MM-dd");
-	public static final NumberFormat floatFormatterSQL;
+	static DateFormat dateFormatter = new SimpleDateFormat("yyyy-MM-dd");
+	static final NumberFormat floatFormatterSQL;
 	//public static NumberFormat floatFormatterBR = null;
-	public static final NumberFormat longFormatter;
-	public static boolean csvWriteEnclosingAllFields = false; //TODO: add prop for csv_write_enclosing_all_fields
+	static final NumberFormat longFormatter;
+	static boolean csvWriteEnclosingAllFields = false; //TODO: add prop for csv_write_enclosing_all_fields
 	
 	static {
 		floatFormatterSQL = NumberFormat.getNumberInstance(Locale.ENGLISH); //new DecimalFormat("##0.00#");

src/tbrugz/sqldump/datadump/Turtle.java

  */
 public class Turtle extends RDFAbstractSyntax {
 
-	public static final String[] NAMESPACE_PREFIXES = { "rdf", "xsd" };
-	public static final String PROP_KEY_COLSEPARATOR = "sqldump.datadump.turtle.keycolseparator"; 
-	public static final String PROP_KEY_INCLUDESCOLNAME = "sqldump.datadump.turtle.keyincludescolname"; 
-	public static final String PROP_KEY_APPENDSTR = "sqldump.datadump.turtle.keyappend"; 
+	static final String[] NAMESPACE_PREFIXES = { "rdf", "xsd" };
+	public static final String PROP_KEY_COLSEPARATOR = "sqldump.datadump.turtle.keycolseparator";
+	public static final String PROP_KEY_INCLUDESCOLNAME = "sqldump.datadump.turtle.keyincludescolname";
+	public static final String PROP_KEY_APPENDSTR = "sqldump.datadump.turtle.keyappend";
 	
 	String baseUrl = null;
 	String keyColSeparator = ";";

src/tbrugz/sqldump/dbmodel/Column.java

 		static String dbid;
 		
 		public static void init(Properties prop) { //DBMS
-				if(prop!=null) {
+			usePrecisionMap.clear();
+			if(prop!=null) {
 					dbmsSpecificProps.clear();
 					dbmsSpecificProps.putAll(prop);
-				}
-				
-				usePrecisionMap.clear();
-				setupPrecisionMap(prop);
+					setupPrecisionMap(prop);
+			}
 		}
 		
 		public static void setProperties(Properties prop) {

src/tbrugz/sqldump/def/DBMSResources.java

 	
 	static final String PROP_FROM_DB_ID_AUTODETECT = "sqldump.fromdbid.autodetect";
 	static final String PROP_DBMS_SPECIFICGRABCLASS = "sqldump.dbms.specificgrabclass";
+
+	static final DBMSResources instance = new DBMSResources();
 	
 	final Properties papp = new Properties(); //TODO: maybe DBMSResources should not depend on processProperties...
 	final Properties dbmsSpecificResource = new ParametrizedProperties();
 		return null;
 	}
 	
-	static DBMSResources instance;
-	
 	public static DBMSResources instance() {
-		if(instance==null) {
+		/*if(instance==null) {
 			instance = new DBMSResources();
-		}
+		}*/
 		return instance;
 	}
 

src_diff/tbrugz/sqldiff/SchemaDiffer.java

 public class SchemaDiffer {
 	static final Log log = LogFactory.getLog(SchemaDiffer.class);
 
-	public static boolean mayReplaceDbId = false;
+	static boolean mayReplaceDbId = false;
 	
 	Set<DBObjectType> doDiffTypes = null;
 

src_mondrian/tbrugz/sqldump/mondrianschema/MondrianSchemaDumper.java

 	//public static final String PROP_MONDRIAN_SCHEMA_ALL_POSSIBLE_DEGENERATED = "sqldump.mondrianschema.allnondimormeasureasdegenerated";
 	
 	//possible aggregate functions: "sum", "count", "min", "max", "avg" and "distinct-count" ; mode, median, first, last, concat?
-	public static final String[] DEFAULT_MEASURE_AGGREGATORS = {"sum"};
+	static final String[] DEFAULT_MEASURE_AGGREGATORS = {"sum"};
 	
 	static String PATTERN_STR_TABLENAME = "\\[tablename\\]";
 	static String PATTERN_STR_PKCOLUMN = "\\[pkcolumn\\]";