1. anatoly techtonik
  2. pycountry

Pull requests

#1 Declined
Repository
Deleted repository
Branch
default (ffc3e55f4629)
Repository
pycountry
Branch
default

Fixed missing logging handler (#3) and some duplicate country/subdivision codes

Author
  1. Fabian Büchler
Reviewers
Description

Fixed the missing logging handler in pycountry.db, described in issue #3.

This revealed a duplicate country code (702 for Sint Maarten should be 534), and some duplicate subdivision codes. Fixed all of these, too.

You're welcome ;-)

Comments (4)

    1. anatoly techtonik repo owner

      Yes, one change per pull request is easier to review, but wait a second before updating manually. IIRC, the DB comes directly from Debian, so the proper fix would be to ensure the Debian version has this fixed and then just update our copy mentioning DB version in commit message.

      1. Christian Theune

        Exactly - the data is the one from Debian, so the policy here is to not apply data fixes to pycountry but only code issues. Every now and then (very irregulary) we can make a new release that includes updates from Debian.