[TIME-13] Incorrect display in portlet.

[Andriy Zhdanov]

I have my portlet set up to display the past two weeks. The first issue that is displayed has '$textUtil.getPrettyHours($timeSpent)' in the columns until it gets to the first worklog entry.

So for example I have an issue that the first work logged for it is on Wednesday. Then the columns show

Monday | Tuesday | Wednesday | Thursday | Friday
$textUtil.getPrettyHours($timeSpent) | $textUtil.getPrettyHours($timeSpent) | 1.2h | 0h | 0h

Then for subsequent rows, the columns display 0h, until time is logged, then show the logged time the rest of the way across, even when no work has been performed on later days.

So for the second line it shows
Monday | Tuesday | Wednesday | Thursday | Friday
0h | 0h | 1.2h | 1.2h | 1.2h

The column totals down at the bottom report the correct total for the day.

At a guess, a variable is not instantiated and reset correctly in a loop.

By johneric/John Enters on Mon, 15 Jan 2007 10:20:40 -0800

[Andriy Zhdanov]

Can't reproducewith plugin version 1.6 on Jira version 3.7.1

By azhdanov on Mon, 15 Jan 2007 14:18:16 -0800

[Andriy Zhdanov]

Can we reopen this please as we also see this behaviour with 1.6 and 3.7.1-#185.

Screenshot attached

NB the first issue was not worked on on Monday.

By leaskc on Tue, 16 Jan 2007 08:17:51 -0800

[Andriy Zhdanov]

See screenshot 2

By leaskc on Tue, 16 Jan 2007 08:18:50 -0800

[Andriy Zhdanov]

Unfortunetly, I'm obsoletely out of idea how it may happen, please advice steps to reproduce. Do you log work done some how specially than with LogWork!default.jspa? Can you send tomcat log (error stack trace)?

By azhdanov on Tue, 16 Jan 2007 12:37:01 -0800

[Andriy Zhdanov]

Oh, I've got it with displaying 5 weeks, fixing...

By azhdanov on Tue, 16 Jan 2007 13:11:35 -0800

[Andriy Zhdanov]

I have the portlet set to display 2 weeks with the reporting day being Monday. I created a new issue on Monday and logged time through the LogWOrk!default.jspa page. The previous week for that issue shows '$textUtil.getPrettyHours($timeSpent)' in every column M-F and 0 in Sat/Sun.

The column for Tuesday shows 0h for every issue since I have not yet recorded any time for today. When I do so for one issue it copies time from the Monday to Tuesday column for every other issue that had time that was recorded on Monday to the Tuesday column.

By johneric on Tue, 16 Jan 2007 13:12:28 -0800

[Andriy Zhdanov]

Just a wild guess but, maybe try adding a #set ($timeSpent = 0) after line 25 of the timesheet-entry.vm (etc.templates.timesheetportlet) file.

By johneric on Tue, 16 Jan 2007 13:57:12 -0800

[Andriy Zhdanov]

Well, you're right, 5 weeks is different way to cause the similar problem.

Anyway I've submitted fix for it, it is available in jar v.1.6 and 1.5

Actually you, John, pointed me to the right place to look at, thank you very much!

I've changed second if condition, to check if there is time spent during this day for particular issue, instead of checking whether time was spent during the day at all. Basing on description, I think it must fix the problem initially described too.

Note, regarding 5 weeks, actually timesheet plugin does not support ranges more than month, and will not support until someone will need it very much.

John, please mark the issue resolved, if it solves the problem you described, as I am actually still not sure

By azhdanov on Tue, 16 Jan 2007 14:32:43 -0800

[Andriy Zhdanov]

Seems to work like it's supposed to.

By johneric on Wed, 17 Jan 2007 08:12:09 -0800

[Andriy Zhdanov]

Fab - looks much better,

Thanks

By leaskc on Thu, 18 Jan 2007 06:29:55 -0800