in version 2.2., CORSFilter default constructor is not public anymore

Create issue
Issue #27 resolved
Christophe Thiebaud created an issue

in version 2.2, after this change:

https://bitbucket.org/thetransactioncompany/cors-filter/pull-request/7/constructor-based-initialization/diff

the default constructor of class com.thetransactioncompany.cors.CORSFilter is not public anymore.

this non-public default constructor make subclassing impossible.

but subclassing can be usefull, for instance this class:

https://github.com/aequologica/runciter/blob/master/src/main/java/net/aequologica/neo/geppaequo/cors/CrossOriginResourceSharingFilter.java

uses subclassing to configure the CORSFilter using annotations.

is there any rationale behind having a non public constructor ?

Comments (5)

  1. Vladimir Dzhuvinov

    Sorry, that has been a terrible mistake :)

    Thank you for spotting it!

    I'll try push a fix later today.

  2. Christophe Thiebaud reporter

    I confirm the issue is fixed with version 2.2.1, which I just grabbed from maven central, tested and even deployed.

    thanks for the quick fix!

    Christophe

  3. Log in to comment