1. Thomas Waldmann
  2. moin-2.0
Issue #126 resolved

diff between PNGs crashes

Thomas Waldmann
repo owner created an issue

create a png item, modify it (upload a slightly modified png), use history, diff these revisions.

crash:

File "/home/tw/w/moin-2.0/MoinMoin/apps/frontend/views.py", line 1523, in _diff_raw return item._render_data_diff_raw(oldrev, newrev)

File "/home/tw/w/moin-2.0/MoinMoin/items/init.py", line 1065, in _render_data_diff_raw oldimage = PILImage.open(oldrev)

File "/home/tw/w/moin-2.0/env/lib/python2.7/site-packages/PIL/Image.py", line 1956, in open prefix = fp.read(16)

AttributeError: 'ProtectedRevision' object has no attribute 'read'

Comments (6)

  1. Thomas Waldmann reporter

    well, it doesn't crash any more, so you fixed the crash.

    but: when I tried it after applying your fix, it didn't crash any more, but it did not show an image diff either, but just some empty page and in the logs I saw some 404 status.

  2. Log in to comment