1. Thomas Waldmann
  2. moin-2.0
  3. Issues
Issue #276 invalid

external links check ignores blanks

Reimar Bauer
created an issue

If you add something like [[http: //google.com]] our external link checker fails.

it makes from that a meta entry of "externallinks": [ "http:%20//google.com"

If you click on the link you can create an item with the "name": " //google.com",

which is also not correct. But also it is not wanted to have a name like "http: //google.com"

Comments (4)

  1. Thomas Waldmann repo owner

    this is not just about blanks, it is rather about whether we should check for valid URLs.

    we could do this on a syntax (according to the URL specs) level, but not more - we can't make completely sure whether an external link is correct.

  2. Thomas Waldmann repo owner

    it's the author's responsibility to recognize and fix typos (no matter whether they are in URLs or other content).

    as we do not "check" links / urls, there can't be a bug for that.

    about offering creation of items with somewhat silly names like //google.com: this will be disallowed by name validation as soon as it is in strict mode.

  3. Log in to comment