1. Thomas Waldmann
  2. moin-2.0
  3. Issues
Issue #278 resolved

pytest 2.3 / moin test issues

Thomas Waldmann
repo owner created an issue

there is a bug that makes pytest 2.3.2 unusable for typical flask apps, see:

https://bitbucket.org/hpk42/pytest/issue/214/pytest-blows-up-when-collecting-modules

after that is solved and the attached patch is applied to our store tests, it should work for us, but still doesn't - likely there is something strange in our conftest.py that makes (pytest's) request.param malfunction somehow. see also http://codereview.appspot.com/6775084 (same as the patch, for review)

needs more research - until it is fixed we require < 2.3 by setup.py.

Comments (4)

  1. Thomas Waldmann reporter

    current state from my workdir.

    as seen in the log, there are a lot of failures/errors still that I can not explain (e.g. test_serialization fails because there is no app context, but tstapp is a autouse fixture, so there should be an app context).

    other failures are somehow expected, e.g. if an app/request context is required by setup_method() - such stuff should be replaced by fixtures.

  2. Holger Krekel

    I've updated pytest on pypi.testrun.org. version 2.3.4dev6:

    • fixes an autouse issue where autouse fixtures would not be considered in certain cases (off-by-one error internally)

    • makes yielded functions honour autouse fixtures, this is a bit a experimental but seems to work (now all tests in MoinMoin/converter/_tests/test_creole_in.py pass for example)

    there are still failures but i think they are mostly due to unconverted tests?!

  3. Log in to comment