1. Thomas Waldmann
  2. moin-2.0
  3. Issues
Issue #394 resolved

Modernized theme creates HTML validation errors on locationline

RogerHaase
created an issue

The validation errors:

line 99 column 46 - Error: Element ul not allowed as child of element span in this context. (Suppressing further errors from this subtree.)
line 114 column 50 - Error: Element ul not allowed as child of element span in this context. (Suppressing further errors from this subtree.)

The HTML causing the errors:

<div id="moin-locationline">

    <span id="moin-pagelocation">
        <span class="moin-pagepath">


                <ul class="moin-bcs-item">
                    <li>
                        <a href="/" class="moin-nonexistent">~</a>
                        <ul class="moin-bcs-subitems">
                            <li><a href="/userprofiles/Home">userprofiles</a></li>

                                <li><a href="/all">all</a></li>
                       </ul>
                    </li>
                </ul>
                <span class="sep">/</span>




                    <ul class="moin-bcs-item">
                        <li><a href="/Home" >
                            Home</a>
                            <ul class="moin-bcs-subitems">

                            </ul>
                        </li>
                    </ul>

        </span>
    </span>
</div>

The problem code is in templates/layout.html. The foobar theme does not have this validation error.

Note #344 and #347 also target layout.html, but appear unrelated.

Comments (3)

  1. RogerHaase reporter

    If you mouseover the "~" link near the top-left, the dropdown display is not beautiful. But that may not be caused by the span tags, rather lack of CSS.

    The HTML validation errors are the ones shown above. If you mean how to do validation, there are several ways:

    While changing the divs to spans will solve the validation error, why is this different from the foobar and basic themes? With modernized:

    • the "all" dropdown link displays a page with History, Tags, and Index links that are more easily accessed by using the tabs > not useful
    • the "userprofiles" dropdown goes to a non-existent page > not useful

    The modernized theme seems wrong, foobar and basic seem right.

  2. Log in to comment