basic theme tries to load non-existent common.css resulting in 404

Issue #425 resolved
Roger Haase created an issue

basic/templates/layout.html includes common.css via {% block head %} {{ super }} from base.html, but there is no common.css for the basic theme. Partial <head> showing link tags:

<link media="all" rel="stylesheet" href="/_themes/basic/css/basic.css">
<link rel="stylesheet" href="/+serve/font_awesome/css/font-awesome.css">
<link rel="shortcut icon" href="/static/logos/favicon.ico">
<link media="all" rel="stylesheet" href="/_themes/basic/css/common.css">
<link media="all" rel="stylesheet" href="/_themes/basic/css/custom.css">

basic.css and the foobar and modernized common.css should be renamed to theme.css. basic.less should be renamed to theme.less and the foobar and modernized main.styl should be renamed to theme.styl. MoinMoin/static/css/common.css is correctly named. base.html must be updated to show the renamed files. must be updated to process the renamed files.

Also, why does basic theme have a custom.css? First thought is to eliminate it and move the rules to basic.less (or main.less/common.less to be ~consistent with main.styl in modernized and foobar). If there is a reason why that cannot be done, there should be a comment in custom.css saying why it exists and what kinds of rules should be placed there.

Comments (5)

  1. Log in to comment