Pull requests

#156 Open
Repository
inducer inducer
Branch
default
Repository
thomaswaldmann thomaswaldmann
Branch
default

Allow colons in arguments. This allows DateTime() macros imported from 1.9 to work.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r 734c81453fbb https://bitbucket.org/inducer/moin-2.0
hg merge 734c81453fbb
hg commit -m 'Merged in inducer/moin-2.0 (pull request #156)'
Author
  1. Andreas Kloeckner
Reviewers
Description
No description

Comments (3)

  1. Thomas Waldmann repo owner

    it would be of course also possible to use double or single quotes, but that would need adding these quotes to all places where the macro gets invoked from the markup.

    not sure if there are negative side effects and which characters we'ld like to allow without requiring quotes.

  2. Andreas Kloeckner author

    Right, it's one or the other. You just have to make a decision. :) My gut feeling says that adding colons is sort of arbitrary, so it might be better to add quoting logic to the importer. I'll send a new pull request.