Byron Clark avatar Byron Clark committed e76fea8

Cleanup logging.

Comments (0)

Files changed (2)

bin/udiskie-umount

     import sys
     import udiskie.umount
 
-    udiskie.umount.cli(sys.argv[1:])
+    sys.exit(udiskie.umount.cli(sys.argv[1:]))

udiskie/umount.py

             logger.debug('Skipping unhandled device %s' % (device,))
 
 def cli(args):
-    logging.basicConfig(level=logging.INFO)
     logger = logging.getLogger('udiskie.umount.cli')
     parser = optparse.OptionParser()
     parser.add_option('-a', '--all', action='store_true',
                       dest='all', default=False,
                       help='all devices')
+    parser.add_option('-v', '--verbose', action='store_true',
+                      dest='verbose', default=False,
+                      help='verbose output')
     (options, args) = parser.parse_args(args)
 
+    log_level = logging.INFO
+    if options.verbose:
+        log_level = logging.DEBUG
+    logging.basicConfig(level=log_level, format='%(message)s')
+
     if options.all:
         unmount_all()
     else:
-        print args
         if len(args) == 0:
             logger.warn('No devices provided for unmount')
+            return 1
 
         for path in args:
             unmount(path)
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.