Get rid of mjsonrpc dialogs. Put it to the console
We would prefer that most of the popup dialogs of mjsonrpc (warning, errors, etc.) would go to the console.
Reason:
- our standard user do not understand these messages
- it sometime clutters the page when multiple error message are popping up
This information is very useful in the console log where we think it should belong to.
Comments (5)
-
-
Then let’s clean up the code. For example in messages.html you will always get a failed rpc from
mjsonrpc_call("cm_msg_retrieve", { "facility": facility, "time" : first_tstamp, "min_messages" : 0 }).then(function(rpc) {
this will always return an undefined value when you do not have new messages and spit and alert. To avoid that one needs to check whether the number of messages >0 before processing an undefined rpc result.
-
Thank you for reporting this problem. I have not seen it before. Do you have a way to reproduce it? Do you mind opening a separate issue for it, tracking two different problems in the same Bitbucket issue does not work well. K.O.
-
see bug 261, we will be adding automatic retry for all 500-series status codes and they will no longer generate popup error dialogs. K.O.
-
- changed status to closed
see bug #276. K.O.
- Log in to comment
There are several problems:
Several ways to tell user something is wrong:
So pick your poison.
For now I will settle on a working recovery code, where after an RPC error, the page will retry the RPC and clear the error message if there is success.
K.O.