history plot editor resets "zero ylow" to "n"

Issue #280 new
dd1 created an issue

the history plot editor is resetting ODB “Zero ylow” to “n” and the checkbox for setting this value has disappeared. now I have to manually edit 8*4 (or more) history plots so they plot correctly again. “zero ylow” is used by the old history plot generator and we should restore the checkbox and change the editor to leave the old value unchanged. K.O.

Comments (7)

  1. dd1 reporter

    for compatibility between old history plot generator and new plots, “zero ylow” set to “y” should mean the same as min=0, max=+inf. (unless min and max have other values? need to check the old history plot generator).

    since the old plot generator is the only way to make long-time-scale plots, we have to keep it around and both plot generators should be compatible in their configuration.

    K.O.

  2. Stefan Ritt

    I removed the “zero ylow” in favour of the min, max values which are more flexible (like you can fix the upper scale and keep the lower one auto-scaling). Rather than putting this back, I would recommend to change existing plots to use the min/max values. If it’s too much manual work (8*4 plots can be done in five minutes), one can invent some code which transfers an existing “zero ylow” automatically into a “min=0, max=+inf”.

  3. dd1 reporter

    list of history plots in the alpha-g test system. I hope we are not demanding that all experiments have to manually update all their history plots just because we wish to remove “zero ylow”. I can give you a list of history plots from the alpha-2 experiment, it is much longer. And BTW, as we update midas in the alpha-2 system it will be me who will have to do all the converting, so I have a direct interest in keeping things compatible. K.O.

    Default Trigger rate  HVPS01  LVDB  LVDB_AGV_INEG  LVDB_AVG_IPOS  LVDB_IPOS  LVDB_INEG  LVDB_test1  DetCooling2  I_vs_temp 
    LVPS    Temp  Current  Voltage 
    VMEPS   Temp  Current 
    Trigger scalers  SC16  SC4  SC32A  SC32B  Clk625 
    PWB00   temp  power 
    TPC mfcrd_ai  Pressure  Flow  PlotKO  GasFlow 
    UPS test 
    LVDB    lvdb01  lvdb02  lvdb01_avg_ineg  lvdb01_avg_ipos  lvdb02_avg_ineg  lvdb02_avg_ipos 
    ADC fpga_temp  sensor_temp0  sensor_temp_min  sensor_temp_max  http_time  temp_board  temp_amp_min  temp_amp_max  sfp_rx_power  sfp_tx_power  sfp_tx_bias  sfp_temp 
    PWB temp_board  v_p2  v_p5  http_time  i_p2  i_p5  sfp_tx_power  sfp_rx_power  sfp_tx_bias  sfp_rx_power_1  v_p2_6  v_p5_6  sfp_special_28  MV2 
    PWBcol0 sfp_rx_power  sfp_tx_power  sfp_tx_bias  v_sca12  v_sca34  i_sca12  i_sca34  v_p2  v_p5  temp_board  i_p5  i_p2 
    PWBcol1 sfp_rx_power  sfp_tx_power  sfp_tx_bias  v_sca12  v_sca34  i_sca12  i_sca34  v_p2  v_p5  temp_board  i_p5  i_p2 
    PWBcol2 sfp_rx_power  sfp_tx_power  sfp_tx_bias  v_sca12  v_sca34  i_sca12  i_sca34  v_p2  v_p5  temp_board  i_p5  i_p2 
    PWBcol3 sfp_rx_power  sfp_tx_power  sfp_tx_bias  v_sca12  v_sca34  i_sca12  i_sca34  v_p2  v_p5  temp_board  i_p5  i_p2 
    PWBcol4 sfp_rx_power  sfp_tx_power  sfp_tx_bias  v_sca12  v_sca34  i_sca12  i_sca34  v_p2  v_p5  temp_board  i_p5  i_p2 
    PWBcol5 sfp_rx_power  sfp_tx_power  sfp_tx_bias  v_sca12  v_sca34  i_sca12  i_sca34  v_p2  v_p5  temp_board  i_p5  i_p2 
    PWBcol6 sfp_rx_power  sfp_tx_power  sfp_tx_bias  v_sca12  v_sca34  i_sca12  i_sca34  v_p2  v_p5  temp_board  i_p5  i_p2 
    PWBcol7 sfp_rx_power  sfp_tx_power  sfp_tx_bias  v_sca12  v_sca34  i_sca12  i_sca34  v_p2  v_p5  temp_board  i_p5  i_p2 
    TMB ColOut  Manifold 
    Chronobox   CB02  H2Oflow 
    TDC temp 
    LVPS02  voltages  currents 
    EVB Statistics 
    Images  Demo Camera 
    

  4. Stefan Ritt

    Actually what we can do is to add code directly on the history page looking for the “Zero ylow” flag. If it’s there and true, the code can modify the ODB with correct min/max values. This is just a few lines of code, which will fix all existing plots, without having to bring back this check box again.

  5. Stefan Ritt

    Actually looking at the code im mhistory.js:463, I see

       if (this.odb["Zero ylow"]) {
          this.autoscaleMin = false;
          this.odb["Minimum"] = 0;
       }
    

    So if “Zero ylow” is in the ODB, it is obeyed. If you do have an old plot which is not showing correctly, send me the URL and I will check.

  6. Log in to comment