mserver rpc_check_channels() crash

[dd1]

in agmini I see an mserver crash in rpc_check_channels() line 16405 sa->close(). it looks like “sa” points to a deleted object. also _server_acceptions contains only one element and it is NULL, so definitely object pointed to be “sa” was deleted. mserver is single threaded so not clear how this could have happened. K.O.

[dd1]

also rpc-check_channels() is missing a null pointer check after sa = _server_acceptions[idx]; this is not the cause of this crash, “sa” is not NULL. K.O.

[dd1]

Rebuild doxygen call graphs, look at call graph for rpc_server_loop() (mserver main loop), call graph for rpc_check_channels(), see the bug. sa->close() after cm_disconnect_experiment() will always crash because cm_disconnect_experiment() closes and deletes all connection objects. K.O.

[dd1]

rpc_check_channels() probable should not call cm_disconnect_experiment() in the “if (rpc_is_mserver)” path. we return RPC_NET_ERROR, rpc_server_loop() exits and mserver.cxx will clean up stuff. K.O.

[dd1]

fixed 980be0bc98c13c0c014b88d500e32e421afc4d04. K.O.