- marked as minor
if SYSTEM buffer exists, but is empty, nothing works
if SYSTEM buffer exists, but is empty, nothing works - programs like mdump give misleading error message about event buffer mismatch saying "existing size is 0" in bm_open_buffer().
when in fact the mismatch is between the requested size and the contents of the buffer header in shared memory. the correct message should say "mismatch against contents of buffer header in shared memory".
also should validate the contents of the buffer header (size, name, etc) before using it.
also instruct the user to delete the shared memory if there is mismatch. (nothing will work if buffer header in shared memory is wrong).
K.O.
Comments (3)
-
reporter -
-
assigned issue to
-
assigned issue to
-
reporter - changed status to resolved
Improved in commit dc20218 - the check for correct buffer name should protect against shared memory that is completely empty (all zero). K.O.
- Log in to comment