colours of history plots have changed

[dd1]

the colours on the history plots have changed, do not seem to correspond to odb colour settings. no time at this moment. to look deeper into this. K.O.

[Stefan Ritt]

Didn't touch it, no idea where it comes from.

[dd1]

Stefan, you broke it by renaming ODB "colour" to "color": https://bitbucket.org/tmidas/midas/commits/97d9e2cc7ed79ef31a26ee953d04e570b1fe1881#chg-src/mhttpd.cxx K.O.

[dd1]

Restored old odb name "colours". K.O.

[Stefan Ritt]

There are two spellings: color (US) and colour (GB). See http://grammarist.com/spelling/color-colour/

Can we agree on one spelling throughout midas? I don't care which one, but having "colour" and "color" mixed all over the place is error prone. That was the reason why I changed the original "colour" to "color" (because you live in Kanada). I might have missed one or two locations, for which I'm sorry. But now we have again the mess of two different spellings. Can we agree on one?

[Pierre-André Amaudruz]

If we're so close to having all changed to European spelling, and this term is for internal code variable, then I would keep it and use it to justify the country of origin of the code. But any of the HTML, JS may require the other spelling. Can we live with it? I would say Yes.

[Stefan Ritt]

You can say that because you don't write HTML code. If you have something like

<div style="colour:red">Hello</div>

then the browser is silently ignoring the colo(u)r and you are puzzled why this is not working. After stepping into this trap about a dozen times, I decided to rename everything to color consistently in midas (like with consistent MB vs. MiB). That saved me lots of trouble. I scanned all C/C++ files and changed all of these, but I overlooked the history panel colours in the ODB which explicitly contain "colour" and not "color". This broke the history display.

If we now go back and rename everything in midas with colour, then each time we work with colo(u)rs we have to think which spelling to use. Sure, we could have color for all HTML code and colour for all C++ code and ODB settings, but sometimes an ODB setting is directly used as a part of some HTML code. Like when I rewrite the history display, I have to move the "colour" from the ODB into "color" in the JavaScript code I will use. Rather annoying.

If we change now everything back to "color", then I see the problem that all running experiments have to change their ODB for the history panels. We can develop some code which automatically changes the ODB "colours" to "color", so users will see no difference. But maybe it's not worth the effort. So let's keep "colour" for the ODB and "color" for all JavaScript code, and I will just step a few more times into the trap.