- edited description
- attached patch-liblzf-001
[tnozaki-liblzf] TNF local patch - introduce reentrant version of lzf_compress
https://mail-index.netbsd.org/source-changes/2010/02/03/msg006253.html
Adjust liblzf to offer the LZF_STATE_ARG API, which is better for small-stack
environments (think bootblocks etc) and no worse elsewise (you can always
just pass the same state argument...) and have correct prototypes when doing
so.
https://mail-index.netbsd.org/source-changes/2012/09/16/msg037329.html
Sigh provide, by default, the dumb "allocate 64K on the stack" variant
of the lzf_compress API by default. This is because there is evidently
code floating around out there in the world with broken autoconf scripts that
don't check for LZF_STATE_ARG in the lzf header files and just assume the
dumb version of the API.We rename the sane API to lzf_compress_r and implement the dumb API in
terms of it. Consequently, bump liblzf major version number. This is
fine because nothing used our liblzf with the old API.
Comments (5)
-
reporter -
reporter - edited description
- attached patch-liblzf-002
-
reporter - attached patch-liblzf-002
- attached patch-liblzf-001
-
reporter this patch is completely wrong
- lzf_compress_r, “_r” suffix meaning reentrant(MT-Safe). but lzfcompress is MT-Safe too(but conmsumption huge stack size). it is wrong naming
- 5th extra argument of LZF_STATE_ARG idea is completely evil, if you want small stack environment, only change HLOG value 16 → 13 with preprocessor
- this changes want install lzfP.h, it’s a private header, don’t install /usr/include
-
reporter - changed status to wontfix
stupid change, not acceptable.
- Log in to comment