citrus_memstream_get8() wrongly increment its read position.

Issue #84 closed
Takehiko NOZAKI repo owner created an issue

see following diff:

diff --git a/lib/libc/citrus/citrus_memstream.h b/lib/libc/citrus/citrus_memstream.h
index baeb14b..24a5b9b 100644
--- a/lib/libc/citrus/citrus_memstream.h
+++ b/lib/libc/citrus/citrus_memstream.h
@@ -165,7 +165,7 @@ _citrus_memory_stream_get8(struct _citrus_memory_stream *ms, uint8_t *rval)
                return -1;

        *rval = _citrus_region_peek8(&ms->ms_region, ms->ms_pos);
-       ms->ms_pos += 2;
+       ms->ms_pos += 1;

        return 0;
 }

currenly this API is only provided, not used so that no harm.

Comments (2)

  1. Log in to comment