Tom Christie avatar Tom Christie committed 9421936 Merge

Merge pull request #45 from sebpiq/master

Clean overloads + fixed a bug in serializers

Comments (0)

Files changed (2)

djangorestframework/mixins.py

             return
         
         # At this point we're committed to parsing the request as form data.
-        self._data = data = self.request.POST
+        self._data = data = self.request.POST.copy()
         self._files = self.request.FILES
 
         # Method overloading - change the method and remove the param from the content.
         if self._METHOD_PARAM in data:
-            self._method = data[self._METHOD_PARAM].upper()
+            # NOTE: unlike `get`, `pop` on a `QueryDict` seems to return a list of values.
+            self._method = self._data.pop(self._METHOD_PARAM)[0].upper()
 
         # Content overloading - modify the content type, and re-parse.
         if self._CONTENT_PARAM in data and self._CONTENTTYPE_PARAM in data:
-            self._content_type = data[self._CONTENTTYPE_PARAM]
-            stream = StringIO(data[self._CONTENT_PARAM])
+            self._content_type = self._data.pop(self._CONTENTTYPE_PARAM)[0]
+            stream = StringIO(self._data.pop(self._CONTENT_PARAM)[0])
             (self._data, self._files) = self._parse(stream, self._content_type)
 
 

djangorestframework/serializer.py

 
         # serialize each required field 
         for fname in fields:
-            if fname in instance:
-                # finally check for a key 'fname' on the instance
-                obj = instance[fname]
-            elif hasattr(self, smart_str(fname)):
-                # check for a method 'fname' on self first
+            if hasattr(self, smart_str(fname)):
+                # check first for a method 'fname' on self first
                 meth = getattr(self, fname)
                 if inspect.ismethod(meth) and len(inspect.getargspec(meth)[0]) == 2:
                     obj = meth(instance)
+            elif hasattr(instance, '__contains__') and fname in instance:
+                # check for a key 'fname' on the instance
+                obj = instance[fname]
             elif hasattr(instance, smart_str(fname)):
-                # now check for an attribute 'fname' on the instance
+                # finally check for an attribute 'fname' on the instance
                 obj = getattr(instance, fname)
             else:
                 continue
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.