hgtk hangs when navigating to revision -1 (000000...)

Alen Siljak avatarAlen Siljak created an issue


I just converted an SVN repository that had two branches. In Mercurial repository one has the changeset 0 as the parent. The other one has revision -1 (000...) as the parent. When clicking on the zeros hyperlink (0000...) in Repository Explorer the hgtk hangs and knocks the processor high up. The link is displayed in the lower right window that displays changesets.

Comments (4)

  1. Steve Borho

    I can verify this on Linux. Clicking on the -1 link causes some kind of endless recycle, eating up your CPU and memory until you kill it. I suspect this is not new.

  2. Steve Borho

    treeview: validate revision before attempting to load

    repo[-1] is the null changeset and can never appear in self.index. Null has other aliases, so looking at ctx.rev() is the safest check.

    Sanity check the revision number here as well, if we fail to acquire a context for it, do not start a load.

    Closes #1000


  3. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.