Yuya Nishihara avatar Yuya Nishihara committed 19b4d0a

revert: do not shadow QDialog.finished signal

Comments (0)

Files changed (1)


         self.cmd = cmdui.Runner(True, self)
-        self.cmd.commandFinished.connect(self.finished)
+        self.cmd.commandFinished.connect(self._onCommandFinished)
         BB = QDialogButtonBox
         bbox = QDialogButtonBox(BB.Ok|BB.Cancel)
-    def finished(self, ret):
+    def _onCommandFinished(self, ret):
         if ret == 0:
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.