Yuya Nishihara avatar Yuya Nishihara committed 43fada9

repomodel: avoid filled.emit() of destroyed HgRepoListModel (fixes #1267)

If QTimer is connected to lambda, it will be alive even after QObject-part of
HgRepoListModel destroyed. As a result, it tries to emit unbound filled signal
causing TypeError, or "underlying C/C++ object has been deleted" error.

Comments (0)

Files changed (1)

tortoisehg/hgqt/repomodel.py

         self.layoutChanged.emit()
         self.ensureBuilt(row=0)
         self.showMessage.emit('')
-        QTimer.singleShot(0, lambda: self.filled.emit())
+        QTimer.singleShot(0, self.filled)
 
     def reloadConfig(self):
         _ui = self.repo.ui
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.