Commits

Yuya Nishihara committed 6d70226

filerevmodel: remove unwanted and unstopped startTimer() (refs #2166)

Since d7e163b8afac, which renamed _fill_timer to timerHandle in super class,
_fill_timer is no-op and never stopped.

I suspect that unstopped _fill_timer hit some bug of PyQt, say, timerEvent()
was somehow triggered while destroying Python object, and caused #2166.

Currently revision graph is loaded on demand, this startTimer() is no longer
needed.

  • Participants
  • Parent commits ed10561
  • Branches stable

Comments (0)

Files changed (1)

File tortoisehg/hgqt/filerevmodel.py

             self.heads = [fl.index[fl.rev(x)][4] for x in fl.heads()]
             self.ensureBuilt(row=self.fill_step/2)
             QTimer.singleShot(0, lambda: self.filled.emit())
-            self._fill_timer = self.startTimer(500)
         else:
             self.graph = None
             self.heads = []