Yuya Nishihara committed 6f2f436

settings: don't reset initial tab to global by addTab()

Since 6e4133f2c630, "thg repoconfig" cannot open repo tab.

If _currentFormChanged is connected before adding tabs, _activeformidx is
overwritten to 0.

Comments (0)

Files changed (1)


         self._activeformidx = configrepo and CONF_REPO or CONF_GLOBAL
         self.conftabs = QTabWidget()
-        self.conftabs.currentChanged.connect(self._currentFormChanged)
         utab = SettingsForm(rcpath=scmutil.userrcpath(), focus=focus)
         self.conftabs.addTab(utab, qtlib.geticon('settings_user'),
         self._restartreqs = set()
+        self.conftabs.currentChanged.connect(self._currentFormChanged)
     def isDirty(self):
         return util.any(self.conftabs.widget(i).isDirty()
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.