Yuya Nishihara committed 79c3315

shelve: don't shadow built-in QDialog.finished (gc)

It disables deletion of modeless ShelveDialog, started from console widget.

It doesn't matter for modal dialog, because PyQt treats QDialog.exec_()
as a special case:

> int exec()
> [...]
> // Transfer ownership back to Python (a modal dialog will probably have the
> // main window as it's parent). This means the Qt dialog will be deleted when
> // the Python wrapper is garbage collected. Although this is a little
> // inconsistent, it saves having to code it explicitly to avoid the memory
> // leak.
> sipTransferBack(sipSelf);

(from sip/QtGui/qdialog.sip)

Comments (0)

Files changed (1)


 class ShelveDialog(QDialog):
-    finished = pyqtSignal(int)
     wdir = _('Working Directory')
     def __init__(self, repo, parent):
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.