Yuya Nishihara avatar Yuya Nishihara committed 8b30a8e

mq: remap persistent indexes of PatchQueueModel only if necessary

This optimizes the common scenario like qpush and qpop. In this case,
the order of the patches is not changed, so layoutChanged is overkill.

Comments (0)

Files changed (1)


     def _updateCache(self):
         # optimize range of changed signals if necessary
+        repo = self._repoagent.rawRepo()
+        if self._series == repo.mq.series[::-1]:
+            self._buildCache()
+        else:
+            self._updateCacheAndLayout()
+        self.dataChanged.emit(self.index(0), self.index(self.rowCount() - 1))
+    def _updateCacheAndLayout(self):
         oldindexes = [(oi, self._series[oi.row()])
                       for oi in self.persistentIndexList()]
                 ni = QModelIndex()
             self.changePersistentIndex(oi, ni)
-        self.dataChanged.emit(self.index(0), self.index(self.rowCount() - 1))
     def _buildCache(self):
         repo = self._repoagent.rawRepo()
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.